I posted a question earlier tonight - PHP Wordpress quotes issue where some quotes were causing me some issues.

An answer was posted suggesting using echo sprintf. This looked very clean and took care of any variable & quoting issues that may occur. My question is, whats the disadvantage of using sprintf? If any?

Why do we use echo if it usually causes issues with mixing HTML and PHP. For reference this was the echoed statement:

echo "<img src='"; bloginfo('template_url'); echo "img/" . $f['mainImage'] . ".png' />";

and the echo & sprintf:

echo sprintf(
    '<img src="%s/img/%s.png" />', 
    get_bloginfo('template_url'), 
    $f['mainImage']
);

Comments

Why echo sprintf() instead of simply printf()?

Written by Wiseguy

I agree with Charles Brunet. By the way you're using two different functions in your code examples. (bloginfo with performs its own echo/print and get_bloginfo which RETURNs the information). The first one could also be: echo "<img src='" . get_bloginfo('template_url') . "img/" . $f['mainImage'] . ".png' />";

Written by Eliasdx

Personally, since you're using doublequotes anyway... to clean up the echo statement I'd change echo to include a lot less concats, but ... just a random preference echo "<img src='".get_bloginfo('template_url')."img/{$f['mainImage']}.png' />";

Written by Anther

Accepted Answer

It's not the echo statement that "causes" problems, it's the lack of information available to newcomers, so I'll try to explain them.

There are four ways of specifying a string in php:

  • Using a single quote

    $str = 'Hello World. This might be a php $variable';

    echo $str; // Outputs: Hello World. This might be a php $variable

Since the string was wrapped in single quote, php engine will not try to interpret $variable as actual variable and the contents of what you see in the quotes will be echoed.

  • Using double quote

    $variable = 'random text'; $str = "Hello World. This will be interpreted as $variable";

    echo $str; // Outputs: Hello World. This will be interpreted as random text

In this example, php will try to find a variable named $variable and use its contents in the string.

  • Heredoc syntax

Heredoc is useful for things such as what you wanted to do - you have a mix of variables, single quotes, double quotes and escaping all that can be a mess. Hence, good php people implemented the following syntax for us:

$str = <<<EOF
<img src="$directory/images/some_image.gif" alt='this is alt text' />
<p>Hello!</p>
EOF;

What will happen is that PHP engine will try to interpret variables (and functions, but I won't post examples on how to do that since it's available at php.net), however you wrapped the string with <<

  • Nowdoc syntax

    $str = <<<'EOF'

    Hello! This wants to be a $variable but it won't be interpreted as one!

    EOF;

It's the same as using a single-quoted string - no variable replacements occur, and to specify something as nowdoc - simply wrap the delimiter with single quote characters as shown in the example.

If you are able to understand these four principles, problems with quotes in your string should go away :)

Written by N.B.
This page was build to provide you fast access to the question and the direct accepted answer.
The content is written by members of the stackoverflow.com community.
It is licensed under cc-wiki